Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: Improve security #346

Merged
merged 3 commits into from
Oct 17, 2024
Merged

ci: Improve security #346

merged 3 commits into from
Oct 17, 2024

Conversation

skarllot
Copy link
Owner

@skarllot skarllot commented Oct 17, 2024 •
edited
Loading

Pull Request

The issue or feature being addressed

  • Using the latest NBGV
  • Permissions too high for docs publishing

Details on the issue fix or feature implementation

  • Pinpoint NBGV version
  • Remove unused configure-pages action
  • Give write permission only to deploy-pages action
  • Run CodeQL for every pull request

Confirm the following

  • I started this PR by branching from the head of the default branch
  • I have targeted the PR to merge into the default branch
  • I have included unit tests for the issue/feature
  • I have successfully run a local build

@codecov Codecov
Copy link

codecov bot commented Oct 17, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.12%. Comparing base (0c6efb8) to head (681b702).
Report is 1 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main     #346   +/-   ##
=======================================
  Coverage   76.12%   76.12%           
=======================================
  Files          52       52           
  Lines         980      980           
  Branches       61       61           
=======================================
  Hits          746      746           
  Misses        221      221           
  Partials       13       13

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@skarllot skarllot merged commit 0daec68 into main Oct 17, 2024
8 checks passed
@skarllot skarllot deleted the enforce-security branch October 17, 2024 01:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fgodoy-lepaho fgodoy-lepaho fgodoy-lepaho approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@skarllot @fgodoy-lepaho